https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5912





--- Comment #3 from Karsten Bräckelmann <[EMAIL PROTECTED]>  2008-08-12 
16:24:50 PST ---
Created an attachment (id=4355)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4355)
proposed fix

Yes, the order as is *is* important. ;)

This patch correctly treats multi-line Received: headers. However, please note
that I tested the patch *briefly* only. In particular, I did not test the
plain-text part of the patch.

Multi-line Received: headers now are concatenated into a single line with a
single space, no embedded multiple spaces or tabs due to the wrapping. This is
important to retain the checking loop as is.

Using an empty string rather than a nicer looking undef, so the checking while
loop does not need to be guarded further.

Unlike the original, I anchored the Received: header match at the beginning of
the line. Or is there any reason not to?

Also, please note that this looping will fail, if the exonerating Received:
header is the *very* last line, without a single following line or even an
empty line. In that case, the foreach loop ends without checking the (possibly
multi-line) Received: header. Checking is delayed until the next line.

Other than that -- code duplication... *sigh*


-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to