https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5965





--- Comment #4 from Justin Mason <[EMAIL PROTECTED]>  2008-08-28 02:28:37 PST 
---
broadly good, but -- I'm not fond of the side-effect change to the PMS::get()
API.  This is a public API for third party plugins and eval rules, so this will
create a lot of noise when they call ->get() in the previous manner, then match
against the returned value without checking for undef first.

Is there some other way we can support our own internal code getting undef
returns, without breaking backwards compat on that API?  I'm thinking a new,
wrapper method around ->get(), which passes a new "magic" value for the
optional $defval argument to the ->_get() method, indicating that returning
undef is acceptable, and if that's not present then the old style of returning
'' on undef is used.


-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to