https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6060
--- Comment #2 from Mark Martinec <[email protected]> 2009-02-06 09:40:29 PST --- > btw it should be no problem to split up the large subs. even if each one was > broken into 100 separate subroutines, I don't think there would be a > noticeable > performance hit. It's analogous to loop unrolling, what's going on here, > basically. There is a complication in Plugin::Check involving code segments being accumulated into evalstr2, which (because of the order of insertion into the final result) for a file-based approach seems to require the use of two files and a final copying to one. On a closer examination the evalstr2 is currently never used, because all code additions to evalstr2 (through add_temporary_method) seem to be prefixed by a test for $self->{main}->{use_rule_subs}, which is currently always false, as the statement in PerMsgStatus is commented out: #$self->{main}->{use_rule_subs} = 1; Was this just an experiment which didn't work out and can be removed, or can it be useful and should be preserved? -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
