https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6143
Sidney Markowitz <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4476|0 |1 is obsolete| | --- Comment #34 from Sidney Markowitz <[email protected]> 2009-07-08 14:33:20 PST --- Created an attachment (id=4482) --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4482) Corrected patch to also prevent an infinite loop as well as the segfault I have committed this new patch that also corrects the infinite loop. Committed to trunk revision 792323 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=792323 ) As I said in the previous comment, this isn't really a fix but is a bulletproofing against the effects of the actual bug which is in BodyRuleBaseExtractor not taking into account encoded characters when checking for a minimum length. If I understand the comments in the code correctly, whenever a compiled rule is labeled ',[l=1]' then it is "lossy" and the scanner uses the compiled code to find a possible match, then runs the perl version to confirm it. Is that correct? If it is, then the effect of this bug is not too bad, as it would, in the case of this rule, cause a match on any line that contains a NUL character and then test that line with the perl version of the rule. So the only effect is extra processing time for an unnecessary scan of each body line by C code for a NUL character, with the perl rule hitting when it should. Justin, I do have a problem in that I can't get any compiled rules to hit. I create a test mail message, verify that with the Rule2XSBody plugin not loaded the rules I expect to hit, then enable the plugin and the compiled rules stop hitting. Any suggestions about where to look for the problem? I'm not confident about testing this bug if I can't get that to work. -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
