https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5891
--- Comment #5 from Mark Martinec <[email protected]> 2009-09-22 05:44:05 PDT --- > Reopening, to solicit some further comments, and document recent work. Now to my question. Considering that an awl.ip field needs to be extended from 10 characters (as in SA 3.2.3) to 16 characters or more to accommodate an /48 IPv6 address (RIPE is allocating /48 blocks to organizations) - perhaps this opportunity could be seized and to also require adding a field awl.signedby, as needed for the topic of this PR. Note that SpamAssassin/MTA can see an IPv6 address in Received header fields even if running on a host with no IPv6 connectivity - e.g. in a header field inserted by a 'trusted' MTA. Doing that could eliminate a need for the auto_whitelist_distinguish_signed option, which is only there for the purpose of compatibility with an unchanged awl SQL database. The less options, the fewer opportunity for support questions, misconfigurations, undertested code ... Also some admins would choose to keep auto_whitelist_distinguish_signed at its default (off) compatibility setting solely out of laziness and for sticking blindly to defaults, which has unfavourable affect on AWL results. So, I propose that with upgrading to SA 3.3.0 and keeping existing AWL database on SQL, one is obliged to do both changes (extend awl.ip and add awl.signedby), not just the first. And to get rid of my compatibility option auto_whitelist_distinguish_signed. The required change is described in sql/README.awl : MySQL: ALTER TABLE awl MODIFY ip varchar(16); ALTER TABLE awl DROP PRIMARY KEY, ADD signedby varchar(255) NOT NULL DEFAULT '', ADD PRIMARY KEY (username,email,signedby,ip); PostgreSQL: ALTER TABLE awl ALTER ip TYPE varchar(16); DROP INDEX awl_pkey; ALTER TABLE awl ADD signedby varchar(255) NOT NULL DEFAULT '', ADD PRIMARY KEY (username,email,signedby,ip); -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
