https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6335
--- Comment #32 from Justin Mason <[email protected]> 2010-03-03 12:09:36 UTC --- hmm. Karsten found a bug: 'I think I might have found a corner-case problem with the patch (in trunk) for bug 6335. The problem appears to be, that $dnsbl_lookup_ips and $is_ip are not independent. + my $cf = $scanner->{uridnsbl_active_rules_revipbl}; + my $dnsbl_lookup_ips = 0; + foreach my $rulename (keys %{$cf}) { + if ($tflags->{$rulename} !~ /\bdomains_only\b/) { + $dnsbl_lookup_ips++; $dnsbl_lookup_ips == 0 IFF *all* $tflags->{$rulename} *do* match /domains_only/ (assumption (1)). Due to + if ($dnsbl_lookup_ips && $dom =~ /^\d+\.\d+\.\d+\.\d+$/) { $is_ip then also is 0, even if $dom indeed *is* an IP. + next if ($is_ip && $tflags->{$rulename} =~ /\bdomains_only\b/); This test later on then fails to skip, because $is_ip is zero. Again, even in the case of $dom actually being an IP. And the respective tflags set to domains_only, as per the corner-case assumption of *all* such rules having that tflag set.' -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
