https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6392
--- Comment #4 from Mark Martinec <[email protected]> 2010-03-30 11:23:51 UTC --- > The fix is to replace all occurrences > sorry, I missed the commit in this ticket. looks good. I believe that was the only one. Thanks for spotting it. But I found a similar case in rulesrc/sandbox/jm/EmailBL.pm - return 0 unless defined @$emails; + return 0 unless @$emails; Also found two cases of 'if/unless keys %hash', which is suboptimal. Under perl 5.12 the 'if/unless %hash' supposedly runs much faster (according to release notes), semantics is the same. trunk: Bug 6392: Test suite fails with perl 5.12.0; some more cleanups according to Bug 6392 comment 4 Sending lib/Mail/SpamAssassin/HTML.pm Sending lib/Mail/SpamAssassin/Plugin/BodyEval.pm Sending rulesrc/sandbox/jm/EmailBL.pm Committed revision 929084. The goto into a construct still needs fixing, then all of this is to be backported to 3.3.2. -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
