https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6362
--- Comment #42 from Kevin A. McGrail <[email protected]> 2010-06-03 17:02:50 EDT --- > The change to DnsResolver.pm is nontrivial and adds new functionality - which > seems > plenty for a minor patch release like 3.3.2. Considering that the main need > for > it is adding a test, and that there are three other DNS-related changes > targeted > for 3.4 (comment 31 and c32), I'd feel more comfortable if they'd go all > together > into 3.4. I don't consider absence of a test in 3.3 is warranting the > nontrivial > change in code. Also, the test is already in trunk and is being evaluated by > Hudson I believe. That makes sense. I had some other discussions about this and it was my confusion that this was only for a test case not knowing that this ALSO added new functionality. I'm +1 for the code for the 3.4 as mentioned in comments 31 and 32. > Not sure I understand the question. The test spawns a self-contained DNS > resolver > with wired-in test zone. The missing (hereby added) functionality is to make > SA use that DNS server (for the test) instead of whatever is in > /etc/resolv.conf. > Don't know if that qualifies for a net test or not: it requires a working > TCP/IP stack on the loopback interface, but does not require network > connectivity. My question dealt with why we need configuration options for a test case. Then I realized it deals with the test and adds new functionality hence the new options. You can safely ignore. -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
