https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6456
--- Comment #3 from Kevin A. McGrail <[email protected]> 2010-06-25 11:40:47 EDT --- (In reply to comment #2) > Created an attachment (id=4786) --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4786) [details] > using utils, replaced static delimiter > > Hmm, when you say central place, do you mean a per file or is it possible to > define this in a more central component? I meant doing something like what you did where this delimiter concept can be reused. I can't recommend a better way than what you did though of course, it likely exists ;-) > Anyway, slightly reformatted patch (using Util qw(am_running_on_windows) for > check and replaced static delimiter). I think I remember from a previous patch that using perl vars and substitutions is bad form. I think you need to change your printf's etc. so that they use substitution to be consistent with the existing code. printf STDERR ("%s [%d] %s: %s%s", $timestamp, $$, $level, $msg, $delimiter) or warn "Error writing to log file: $!"; Regards, KAM -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
