https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6492

--- Comment #1 from Mark Martinec <[email protected]> 2010-11-25 18:47:29 
UTC ---
> I believe we should check the RBL rules to ensure they end in a '.'

I believe we should remove the trailing dot in all rules for brevity
and to avoid confusion, and to update the documentation to note that
the trailing dot is optional and carries no semantics in these rules.

> Does this require a patch?
> Either the documentation is wrong or we need to fix the rule definition by
> adding the trailing period.  (file:  updates_spamassassin_org/72_active.cf )

This requires a patch to update the documentation.

myself:
> I believe the dot is optional as far as the DNS resolving is concerned.
> I'm not sure if there is some corner piece of code still relying on the dot.
> If there is, it should be fixed IMO and the docs changed, making the
> dot officially optional.

Confirmed:

$ man Net::DNS::Resolver
send
  Performs a DNS query for the given name.  Neither the searchlist nor
  the default domain will be appended.

(this is unlike methods search() and query(), which use a
search list or a default domain name).

SpamAssassin only uses a method Net::DNS::Resolver::send(),
never the search() or query().


> Tom Schulz:
> The resolver code is often configured to try to add various suffixes to 
> the host name if it does not resolve in an attempt to make it resolve.
> A trailing period tells the resolver not to do this. If the name as given
> does not resolve, then the resolver just quits.

This applies to system resolver's routines, but does not apply
to Net::DNS::Resolver::send()

> Kevin A. McGrail:
> I've long since removed search domains out of my resolve.conf
> just for this issue.

That's a good idea anyway, but not necessary for the sake of SpamAssassin.

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to