https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6500
--- Comment #3 from Mark Martinec <[email protected]> 2011-01-07 14:14:32 UTC --- I agree, it doesn't make sense to have two sets of 'originating' header field names used in two places: in SA::Message/Metadata/Received.pm and in the DNSEval.pm plugin, especially when both sets are identical by default, but one is hard-wired and the other is configurable. Better to use the same configurable set to be used in both places for consistency and flexibility, like your patch provides. (I'm not sure whether the DNSEval.pm plugin needs this special handling of 'originating' header fields at all, considering that they are already converted to synthetic Received header fields by the Received.pm. But that's probably a topic for some other PR. One could also hope these would be inserted into the Received trace list in the position where they occur in the header section instead of being appended at the end. A yet another PR I guess). +1 for your patch trunk: Bug 6500: clear_originating_ip_headers seems to be broken Sending lib/Mail/SpamAssassin/Message/Metadata/Received.pm Committed revision 1056466. -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
