https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6567

           Summary: Clean up zen rbl rules
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Rules (Eval Tests)
        AssignedTo: [email protected]
        ReportedBy: [email protected]
                CC: [email protected]


What's the deal with some RBLs using lastexternal, and some using firsttrusted?

Currently, we have:

header __RCVD_IN_ZEN eval:check_rbl('zen', 'zen.spamhaus.org.')
header RCVD_IN_SBL   eval:check_rbl_sub('zen', '127.0.0.2')
header RCVD_IN_XBL   eval:check_rbl('zen-lastexternal', 'zen.spamhaus.org.',
'127.0.0.[45678]')
header RCVD_IN_PBL   eval:check_rbl('zen-lastexternal', 'zen.spamhaus.org.',
'127.0.0.1[01]')
header RCVD_IN_CSS   eval:check_rbl_sub('zen', '127.0.0.3')

Shouldn't that be this?

header __RCVD_IN_ZEN eval:check_rbl('zen', 'zen.spamhaus.org.')
header RCVD_IN_SBL   eval:check_rbl_sub('zen-firsttrusted', '127.0.0.2')
header RCVD_IN_XBL   eval:check_rbl_sub('zen-firsttrusted',
'^127\.0\.0\.[45678]$')
header RCVD_IN_PBL   eval:check_rbl_sub('zen-firsttrusted',
'^127\.0\.0\.1[01]$')
header RCVD_IN_CSS   eval:check_rbl_sub('zen-firsttrusted', '127.0.0.3')

1) Change XBL and PBL to use check_rbl_sub.

2) Switch everything to -firsttrusted.  I believe -lastexternal ignores
trusted_networks, which I don't think is appropriate?
And for the ones that don't have -lastexternal or -firsttrusted, I think it's
checking *all* untrusted hops?  Is that really best?

"'-firsttrusted' at the end of the set name. That should test the IP address of
the relay that connected to the most remote trusted relay."

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to