https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6456
Kevin A. McGrail <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5002|0 |1 is obsolete| | --- Comment #8 from Kevin A. McGrail <[email protected]> 2011-11-01 17:08:15 UTC --- Created attachment 5003 --> https://issues.apache.org/SpamAssassin/attachment.cgi?id=5003 Revised Carriage Return patch to use $/ (In reply to comment #7) > (In reply to comment #6) > > Revised patch to use sprintf with variable placeholder for delimiter > > Did you actually read comment 4? ;) > > All that M::SA::Util::am_running_on_windows() code and explicitly setting your > own custom $delimiter might not be necessary. Basically, replacing the 4 > occurrences of \n with $/ should do the trick, and make Perl magically use the > appropriate "newline" sequence. > > Since $/ isn't a custom var, it should even be fine to use directly as a > replacement for \n in the sprintf() string -- I'd be rather scared if it ever > contains a %. Sorry, I think I hyperfocused on why (am_running_on_windows()) wouldn't work. Attached is a compromise since I feel better sanitizing it to make sure it's ok. This one passes make test! -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
