https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5185
Kevin A. McGrail <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #19 from Kevin A. McGrail <[email protected]> 2012-02-12 19:32:23 UTC --- > Well, that seems fine, and certainly solves my problem. I've applied the > patch, > and can confirm that I finally have consistent msgids between SMTP time and > subsequent relearning :) Excellent. > However, a few thoughts: > - stripping out the LFs seems like overkill to me - just removing CRs would > do > the job Between unix and dos and mta handling, to me, it seemed safest to remove all of them and be done with it. > - $body could be utterly huge, so removing all the CRs and LFs could be > expensive - particularly since we know we'll only look at the first 1024 > bytes. > But given all the other work spamassassin does, perhaps this is a complete > non-issue? No, this is a good point. I'll move the cr/lf strip to AFTER the body is reduced so it can be more efficient. svn commit -m 'Changing the way the msgid is calculated to remove last received and to also remove cr/lf from the body. bug 5185.' Sending lib/Mail/SpamAssassin/Plugin/Bayes.pm Transmitting file data . Committed revision 1243302. -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
