On Feb 21, 2012, at 9:05 AM, Axb wrote:

> On 02/21/2012 03:36 PM, Michael Parker wrote:
>> Do you need to also change the regex?
> 
> ??? you mean other than add the TLDs to the list?

Yep, notice the comment right below where you added your comments:

#
# Remember to also change regexp below when updating!

You need to update $VALID_TLDS_RE, see the file for the command line todo that.

If you don't update the regex then your changes will only half work.

Michael


> 
>> Michael
>> 
>> On Feb 21, 2012, at 7:04 AM, [email protected] wrote:
>> 
>>> Author: axb
>>> Date: Tue Feb 21 13:04:42 2012
>>> New Revision: 1291757
>>> 
>>> URL: http://svn.apache.org/viewvc?rev=1291757&view=rev
>>> Log:
>>> see
>>> https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6734
>>> 
>>> Modified:
>>>    spamassassin/trunk/lib/Mail/SpamAssassin/Util/RegistrarBoundaries.pm
>>> 
>>> Modified: 
>>> spamassassin/trunk/lib/Mail/SpamAssassin/Util/RegistrarBoundaries.pm
>>> URL: 
>>> http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Util/RegistrarBoundaries.pm?rev=1291757&r1=1291756&r2=1291757&view=diff
>>> ==============================================================================
>>> --- spamassassin/trunk/lib/Mail/SpamAssassin/Util/RegistrarBoundaries.pm 
>>> (original)
>>> +++ spamassassin/trunk/lib/Mail/SpamAssassin/Util/RegistrarBoundaries.pm 
>>> Tue Feb 21 13:04:42 2012
>>> @@ -44,6 +44,12 @@ use vars qw (
>>> # as of 2008-02-08, e.g. http://en.wikipedia.org/wiki/.so_%28domain_name%29
>>> #     bv gb pm sj so um yt
>>> #
>>> +# As per bug #6734
>>> +# Re-enable .so .pm .yt in 2012-02-21
>>> +#   
>>> http://www.afnic.fr/fr/produits-et-services/autres-domaines-de-premier-niveau/
>>> +
>>> +#   http://www.iana.org/domains/root/db/so.html
>>> +#
>>> # Remember to also change regexp below when updating!
>>> 
>>> foreach (qw/
>>> @@ -55,10 +61,10 @@ foreach (qw/
>>>   in info int io iq ir is it je jm jo jobs jp ke kg kh ki km kn kp kr kw
>>>   ky kz la lb lc li lk lr ls lt lu lv ly ma mc md me mg mh mil mk ml mm
>>>   mn mo mobi mp mq mr ms mt mu museum mv mw mx my mz na name nc ne net
>>> -  nf ng ni nl no np nr nu nz om org pa pe pf pg ph pk pl pn pr pro ps
>>> -  pt pw py qa re ro rs ru rw sa sb sc sd se sg sh si sk sl sm sn
>>> +  nf ng ni nl no np nr nu nz om org pa pe pf pg ph pk pl pm pn pr pro ps
>>> +  pt pw py qa re ro rs ru rw sa sb sc sd se sg sh si sk sl sm sn so
>>>   sr st su sv sy sz tc td tel tf tg th tj tk tl tm tn to tp tr travel tt
>>> -  tv tw tz ua ug uk us uy uz va vc ve vg vi vn vu wf ws ye za
>>> +  tv tw tz ua ug uk us uy uz va vc ve vg vi vn vu wf ws ye yt za
>>>   zm zw
>>>   /) {
>>>   $VALID_TLDS{$_} = 1;
>>> 
>>> 
>> 
> 

Reply via email to