https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6872
--- Comment #8 from Mark Martinec <mark.marti...@ijs.si> --- (In reply to comment #3, by Willem Toorop) Now back to the original problem. > I believe you can also work around the issue by putting a space in the > version TXT resource record and an @ in the mirror TXT resource record, > like this: > > 2.3.3.updates.spamassassin.org. TXT "1418219 " > mirrors.updates.spamassassin.org. TXT > "http://anonym...@spamassassin.apache.org/updates/MIRRORED.BY"; > > The space and the @ will force a double quoted return value from rdatastr > even with the new Net::DNS. > I have tested this with sa-update version svn917659 running on Perl version > 5.12.4 on FreeBSD ... This looks like a good and innocent-enough workaround for a bug in SpamAssassin caused by the change in Net::DNS. I tested it with SA 3.3 (uses wget) and 3.4(trunk) (uses curl or wget or fetch or wget), and it seems to do the job, while allowing Net::DNS folks to proceed with their wish of retaining this new behaviour. (there is a lot to be said about the incorrect assumption throughout most of the SpamAssassin code that the Net::DNS API is 8-bit clean, conflicting with their (silly, in my view) concept that the API uses the same encoding as zone ascii text files - but I'll leave that to another posting) > I would like to know if your going to release with the fix (or apply the > trick just mentioned) shortly, to asses whether we need to revert the > behaviour of TXT RR's or not... Considering the time it takes/took some distributions and some installations to pick up a new version of SpamAssassin in the past, I think it is futile to think of going into trouble of releasing a 3.3.3 just to fix this problem, knowing that it will only reach a very limited audience. I think adopting Willem's suggestion is a good (yet hackish) short term solution until the 3.4 can be released to a general public (noting that several sites are already using 3.4(trunk) in production). > PS. I have the intention to e-mail about upcoming releases to developers > that use Net::DNS in their packages in the future, hopefully with the effect > that such nasty issues come up before release. Thanks, good idea. > PS2. I have tested new Net::DNS with spamassassin before release, but did > not notice this issue because sa-update was quiet as normal. Neither did I :) > Shouldn't sa-update at least give a warning when it is unable to determine > whether it needs to update or not? It does, as far as I can tell: spamassassin-3.3(branch): # sa-update http: GET 3.3 request failed: 400 URL must be absolute: 400 URL must be absolute error: no mirror data available for channel updates.spamassassin.org channel: MIRRORED.BY contents were missing, channel failed (exit status 4) spamassassin(trunk): # sa-update channel: no 'mirrors.updates.spamassassin.org' record found, channel failed (exit status 4) and with "1418219 " but without "anonymous@": # sa-update error: no mirror data available for channel updates.spamassassin.org channel: MIRRORED.BY file location was not in DNS, channel failed (exit status 4) -- You are receiving this mail because: You are the assignee for the bug.
