2014-02-20 Tomasz Potega wrote:
I have run into some problems trying to upgrade to 3.4.0. The '-x' ('--nouser-config') option of spamd doesn't seem to work correctly.Tracing the spamd child process I can see it tries to open a user_prefs file of the pattern (absolute path):
[...]
The cause can be traced to changes in untaint_var() - instead of returning undef for $userdir, it just... returns, shifting the arguments. Shouldn't the code read more like: --- Util.pm.orig 2014-02-07 09:36:28.000000000 +0100 +++ Util.pm 2014-02-20 14:47:09.879293333 +0100 - return if !defined $_[0]; + return undef if !defined $_[0];
Agreed, it's a bug. Your fix is alright. While in most other calls it does not matter, in this case it is wrong. Please open a bug report. Probably this happened for taking some advise from Perl::Critic too literally. Mark
