On 08/19/18 03:32, Kevin A. McGrail wrote:
> Hi All,
>
> 3.4 and trunk fail similarly:
>
> Test Summary Report
> -------------------
> t/relaycountry_geoip.t (Wstat: 256 Tests: 2 Failed: 1)
> Failed test: 2
> Non-zero exit status: 1
> t/urilocalbl_geoip.t (Wstat: 512 Tests: 3 Failed: 2)
> Failed tests: 2-3
> Non-zero exit status: 2
>
> Can anyone else confirm? Giovanni, is this stuff you were working on with
> those plugins and the free db issues from maxmind?
>
> I have Geo::IP installed but not configured for SA or anything.
>
> Looks like the tests assume the plugin is configured or something?
>
it assumed that databases are installed, it seems that some os has separated
packages for libraries and databases.
both regression tests fixed with commit r1838364 and r1838365.
Giovanni
> I don't think use constant HAS_GEOIP => eval { require Geo::IP; }; is enough
> for the test.
>
> t/relaycountry_geoip.t ............ Odd number of elements in hash assignment
> at t/relaycountry_geoip.t line 37.
> Use of uninitialized value $patterns{" X-Spam-Relay-Country: US "} in string
> eq at SATest.pm line 749, <IN> line 113.
> t/relaycountry_geoip.t ............ 1/2 Not found:
> X-Spam-Relay-Country: US = X-Spam-Relay-Country: US at
> t/relaycountry_geoip.t line 42.
>
> # Failed test at SATest.pm line 783.
> Output can be examined in: log/d.relaycountry/0
>
> &
>
> t/urilocalbl_geoip.t .............. Aug 18 20:48:29.178 [9620] warn: plugin:
> failed to parse plugin (from @INC): Can't locate GeoIP2/Database/Reader.pm in
> @INC (@INC contains: lib ../blib/lib @@INSTALLSITELIB@@
> /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl
> /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at
> ../blib/lib/Mail/SpamAssassin/Plugin/URILocalBL.pm line 428.
> Aug 18 20:48:29.178 [9620] warn: BEGIN failed--compilation aborted at
> ../blib/lib/Mail/SpamAssassin/Plugin/URILocalBL.pm line 428.
> Aug 18 20:48:29.178 [9620] warn: Compilation failed in require at (eval 100)
> line 1.
> t/urilocalbl_geoip.t .............. 1/3 Not found: north America =
> X_URIBL_NA at t/urilocalbl_geoip.t line 44.
>
> # Failed test at SATest.pm line 783.
> Not found: USA = X_URIBL_USA at t/urilocalbl_geoip.t line 44.
>
> # Failed test at SATest.pm line 783.
> Output can be examined in: log/d.urilocalbl/0
> # Looks like you failed 2 tests of 3.
>
>
> --
> Kevin A. McGrail
> VP Fundraising, Apache Software Foundation
> Chair Emeritus Apache SpamAssassin Project
> https://www.linkedin.com/in/kmcgrail <https://www.linkedin.com/in/kmcgrail> -
> 703.798.0171
>
> --
> Kevin A. McGrail
> VP Fundraising, Apache Software Foundation
> Chair Emeritus Apache SpamAssassin Project
> https://www.linkedin.com/in/kmcgrail - 703.798.0171
