https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7006

Bill Cole <billc...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |billc...@apache.org

--- Comment #4 from Bill Cole <billc...@apache.org> ---
Wouldn't it make more sense to keep the version identifier a build-time
parameter  rather than a runtime parameter? That code would make the resulting
sa-update script give the version of the module prepended to the svn revision
of the sa-update.raw at build time. 

This would get everything at build time:

Index: sa-update.raw
===================================================================
--- sa-update.raw       (revision 1840061)
+++ sa-update.raw       (working copy)
@@ -26,7 +26,7 @@
   # Subversion keyword "$Id$" has been successfully expanded.
   # Doesn't happen with automated launchpad builds:
   # https://bugs.launchpad.net/launchpad/+bug/780916
-  $VERSION = 'svn' . (split(/\s+/, '$Id$'))[2];
+  $VERSION = '@@VERSION@@' . 'svn' . (split(/\s+/, '$Id$'))[2];
 }

 my $PREFIX          = '@@PREFIX@@';             # substituted at 'make' time

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to