Henrik K wrote on 10/05/22 4:21 pm:
A quick hack to run it without taint, created t/perlcritic.t which contains:
#!/usr/bin/perl
$ENV{'PATH'} = '/bin:/usr/bin';
-d "xt" && "$^X xt/60_perlcritic.t" =~ /(.*)/ ||
"$^X ../xt/60_perlcritic.t" =~ /(.*)/;
exec($1);
I submitted a bug report and a PR to Perl-Critic, but I see that their
last commit was in October and they have 33 PRs languishing, so I'm not
holding my breath.
I was about to say that setting PATH would break it when I use plenv or
perlbrew to try out different perl versions, but then I noticed the $^X
which does the job nicely.
Since everything is passing the perlcritic test and it runs so quickly,
I'm +1 about adding it to the tests in t/. If we do that, we could
remove the explicit invocation of it in xt/run_release_test_suite.sh
because it will be part of t/*.t. If perl-critic ever fixes the bug we
can then put the original test in t/ and get rid of the kludge to strip -T.
