On Thu, May 19, 2022 at 04:11:53PM +0200, Michael Storz wrote:
> Am 2022-05-19 11:53, schrieb bugzilla-dae...@spamassassin.apache.org:
> > https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7987
> > 
> > --- Comment #28 from Henrik Krohns <apa...@hege.li> ---
> > A quick cleanup to tidy things:
> > 
> > - Use rule_ready() everywhere instead of direct tests_already_hit modify
> 
> Is this really necessary? It introduces thousands of additional subroutine
> calls.

Not sure why you even ask.  Why do functions exist?  Do you now prefer to
duplicate same code blocks everywhere?

> The algorithm you have now implemented looks too complicated and does not
> convince me.

Maybe for once you could post an actual tested and benchmarked patch,
instead of some random code snippets and comments?  :-) There's only so much
time I can spare myself.

Reply via email to