https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8034
Bug ID: 8034
Summary: [REVIEW] t/dnsbl_subtests.t test failure when
Net::DNS::Nameserver is not installed
Product: Spamassassin
Version: 4.0.0
Hardware: All
OS: All
Status: NEW
Severity: blocker
Priority: P2
Component: Building & Packaging
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: Undefined
Created attachment 5803
--> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5803&action=edit
patch to fix this issue
In bug 7052 we decided to make Net::DNS::Nameserver an optional dependency as
it is only required for the t/dnsbl_subtests.t tests. The change there was done
in DependencyInfo.pm where it is listed as an optional module.
However, we never made it actually optional in t/dnsbl_subtests.t and now it
breaks on CPAN test machines that run CentOS 7 and which because of the reasons
discussed in the comments thread in bug 7052 don't have Net::DNS::Nameserver
installed.
The attached patch modifies t/dnsbl_subtests.t so that it conditionally
requires Net::DNS::Nameserver and skips the tests if it is not there.
It also changes the designation in Makefile.PL of Net::DNS::Nameserver from
being optional for runtime to being optional for testing. DependencyInfo.pm
only makes that distinction in the comments it displays, but
ExtUtils::MakeMaker does distinguish between runtime and test-only
dependencies.
Note that on other than CentOS 7 machines, Net::DNS::Nameserver is brought in
with Net::DNS, which is a required module, and they can't be separated. This
patch can be tested on non-CentOS 7 systems to verify that it doesn't break
anything, but testing that t/dnsbl_subtests.t doesn't fail when there is no
Net::DNS::Nameserver can only be done in CentOS 7 using the native perl and
modules installed from yum (not the Cpanel installed perl and modules). I did
test that.
Please vote on the patch.
--
You are receiving this mail because:
You are the assignee for the bug.
