https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050

--- Comment #31 from Henrik Krohns <[email protected]> ---
(In reply to Sidney Markowitz from comment #30)
> (In reply to Henrik Krohns from comment #28)
> > It certainly does require "use Win32" here, just like mentioned in
> > https://perldoc.perl.org/Win32
> > 
> > 
> > STRAWBERRY
> > 
> > C:\Strawberry>perl\bin\perl -e "print
> > Win32::GetFolderPath(Win32::CSIDL_COMMON_APPDATA());"
> > Undefined subroutine &Win32::CSIDL_COMMON_APPDATA called at -e line 1.
> 
> This is really strange. I expected it to be required, and I get the same
> result when I run that command in Strawberry perl, but the reason I said it
> is not necessary is because the v3 patch I uploaded doesn't have any use or
> require Win32 anywhere in the source tree and I'm able to build and run make
> test without a problem. I even added a dbg line after the call to make sure
> it was called and got a return value, and it did. What am I missing?

Likely it's loaded by some deeper module that SA depends on..

> If we do have a require, is it better to put it in a BEGIN block with if
> (am_running_on_windows()) around the require so it only gets done once at
> compilation?

Sure

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to