https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7892

tbsmar...@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---
                 CC|                            |tbsmar...@gmail.com

--- Comment #5 from tbsmar...@gmail.com ---
Patch finally arrived at my system - and ... it doesn't fix anything.
Sorryy for not looking at the patch at the time.

Note: I'am not really into perl at all so i may be wrong.
But for me it looks like this revision 1887889  seems to allow this:

   color: !important;

Because it's a simple copy & paste of the 7778 solution to allow the special
'inherit' value. However needed is this:

   color: white !important;
   background-color: white !important;


I guess a fix should look like this:

@@ -515,6 +515,9 @@
          if (/^\s*(background-)?color:\s*(.+?)\s*$/i) {
            my $whcolor = $1 ? 'bgcolor' : 'fgcolor';
            my $value = lc $2;
+           # Strip of trailing !important to prevent parsing as 'invalid
color'
+           # (Bug 7892)
+           $value =~ s/^([^\s]+)\s*!important$/$1/;

            if ($value =~ /rgb/) {
              $value =~ tr/0-9,//cd;
@@ -527,10 +530,6 @@
               # do nothing, just prevent parsing of the valid
               # CSS3 property value as 'invalid color' (Bug 7778)
             }
-            elsif ($value eq '!important') {
-              # do nothing, just prevent parsing of the valid
-              # CSS3 property value as 'invalid color' (Bug 7892)
-            }
            else {
              $new{$whcolor} = name_to_rgb($value);
            }

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to