https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8092
Bug ID: 8092
Summary: compat plan for whitelist/welcomelist is confusing
Product: Spamassassin
Version: 4.0.0
Hardware: PC
OS: NetBSD
Status: NEW
Severity: minor
Priority: P2
Component: Documentation
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: Undefined
The change from white to welcome is confusing and not explained enough in the
release notes and wiki page.
Specifically, there seems to be compat for "whitelist_from" etc. in config
files, and that seems to be entirely separate from what rules are called. This
is sort of explained, but not really. The missing point for users is that the
rule renaming in enable_compat has nothing to do with config file contents. Or
maybe I'm wrong.
The new init.pre has enable_compat welcomelist_blocklist. However init.pre is
said to be where customizations go, so people are going to end up without that
in their config, as did I. (There's a larger issue that config files should be
either from the distribution not to be modified, or wholly for users to modify,
to play nice with packaging.) The wiki text does not explain that to get the
new behavior you have to add a compat option. This needs to be
hit-over-the-head clear because it does not make sense to have to turn on a
compat option to get the new standard behavior.
It seems obvious to me, but maybe I'm wrong, that the enable_compat option is
backwards. If not set, one should just get the new names. If something is
set, then the old names should appear as well.
It is unclear to people why they should choose or not choose to enable_compat.
As I see it, it should be enabled (new rules only), for most people, and the
reasons not to are if you have config that rescores those rules, or meta rules
that reference them, or you are parsing SA output and looking for them. All
of that should be fixed, and compat to be able to fix async is of course fine.
For the release, what's needed is a better explanation in release notes and
wiki, so that a clone of me starting over from going to read would not be
confused.
I would also want to flip the compat option to be whitelist_blacklist, invert
the sense, and not put it in init.pre. Thus people that want the old names
have to turn it on, and people that don't need them (99%?) don't need to do
anything.
(Rewritten from a users@ post after KAM asked to file a bug.)
--
You are receiving this mail because:
You are the assignee for the bug.
