https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8097

            Bug ID: 8097
           Summary: t/mkrules.t fails with old perl versions
           Product: Spamassassin
           Version: 4.0.0
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P2
         Component: Regression Tests
          Assignee: [email protected]
          Reporter: [email protected]
  Target Milestone: Undefined

The change made to fix bug 7692 makes use of the environment variable
TEST_ACTIVE as an indicator that tests are being run. That variable is set by
Test::Simple, but only since version 1.302067. Perl version 5.24 and older came
bundled with older versions of Test::Simple as a core module. This causes
t/mkrules.t and t/mkrules_else.t to break when run under perl older than 5.26
unless Test::Simple is upgraded.

This can be fixed by adding Test::Simple minimum version 1.302067 as a test
requirement in Makefile.PL. This can replace the currently existing unversioned
entry for Test::More because Test::Simple is the correct designation for the
module bundle that includes Test::More as a submodule.

Since there is no problem with any version of perl since 5.26, and the tests
are already failing on any system with an old Test::Simple, I see no need to
make the tests check the version and skip running if the module is too old.
However, I'll add the minimum required version to the use Test::Simple so that
if someone does try to install in an environment without the required version
the test failure message will be self-explanatory.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to