https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8098

Sidney Markowitz <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #1 from Sidney Markowitz <[email protected]> ---
Created attachment 5873
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5873&action=edit
patch adding table name in sql statement

I'm showing my lack of SQL knowledge.

When I change SQLBasedAddrList.pm line 310 from 'totscore = totscore + ?' to
'totscore =+ ?' the t/sql_based_welcomelist.t fails using SQLite (which also
uses that line of code).

Tracking down what SQL documentation has to say about the =+ operator, I found
that there is no such thing. totscore =+ 10 is the same as totscore = +10 which
makes it valid syntax but not a self increment operator like the += operator in
other languages.

It looks like the correct fix is to make it totscore =
$self->{tablename}.totscore  + ?

I have attached a patch for perusal by people who know SQL better than I do and
who have access to postgres for testing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to