https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8409
--- Comment #2 from Sidney Markowitz <[email protected]> --- Created attachment 6074 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=6074&action=edit suppress perlcritic warning for return undef; when can't prove return; is safe Attachment 6073 patches every instance of return undef; into just return; where a Claude-assisted scan was able to prove that it could never be called in such a way as to make that change unsafe. This attachment changes all the other instances of return undef; to suppress the perlcritic warning with a comment referring to this Bugzilla issue. Note that the function get_all in GeoDB is a special case. Strictly speaking it can be shown based on the value it returns in the branch that does not return undef; it can not be called by code that will both work with the normal return and break with a return; But since no actual callers of GeoDB can be found and it is written to be called by external plugins that we know nothing about, I'm taking the more conservative position of treating get_all the same as all the other subs in GeoDB. That's documented in the comments at the beginning of the attached patch file. -- You are receiving this mail because: You are the assignee for the bug.
