https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8421
Bug ID: 8421
Summary: Hidden undiscussed dependencies in "Handler" features.
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Hardware: PC
OS: Mac OS X
Status: NEW
Severity: normal
Priority: P2
Component: Building & Packaging
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: Undefined
The new handler functionality and its tests require the tesseract package and
one test requires something called "heif-convert" which code comments claim is
in "libheif" but which is not installed by the libheif package on FreeBSD.
Apparently at some point libheif changed the "real name" of that tool to
"heif-dec" and now the build adds a symlink for the "old" name, an addition
which the FreeBSD packager removes, perhaps errantly as the patchfile removes a
whole conditional checking for Windows.
I do not recall (and cannot find) any discussion of adding these optional(?)
dependencies. They are not tested for or mentioned in the output of
Makefile.PL. The are not mentioned in INSTALL. Tesseract is mentioned in
UPGRADE and build/announcements/4.0.3.txt, libheif and heif-convert are not.
Both libheif and tesseract have substantial recursive dependencies which users
should be made aware of prior to upgrading.
Proposal:
1. Update SA to use 'heif-dec' (the cononical name) instead of 'heif-convert'
(the symlink name on Linux which is a duplicated file on Windows.)
2. Add mention of the new dependencies to INSTALL, expand mention in UPGRADE
and 4.0.3.txt to include libheif.
3. Add check for tesseract and libheif to Makefile.PL
Because this involves documentation of new features, I believe it should block
release.
--
You are receiving this mail because:
You are the assignee for the bug.
