Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/43#discussion_r10174727
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockFetcherIterator.scala ---
@@ -146,6 +146,12 @@ object BlockFetcherIterator {
}
protected def splitLocalRemoteBlocks(): ArrayBuffer[FetchRequest] = {
+ // Make remote requests at most maxBytesInFlight / 5 in length; the
reason to keep them
+ // smaller than maxBytesInFlight is to allow multiple, parallel
fetches from up to 5
+ // nodes, rather than blocking on reading output from one node.
+ val maxRequestSize = math.max(maxBytesInFlight / 5, 1L)
+ logInfo("maxBytesInFlight: " + maxBytesInFlight + ", maxRequestSize:
" + maxRequestSize)
+
--- End diff --
The only change here is to move this up. The reason is that there is no
reason to calculate and log this in the inner loop, because its the same for
all iterations of that loop. Logging it in the inner loop also means the same
message is logged a bunch of times.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
