Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/38#discussion_r10178681
  
    --- Diff: bin/pyspark ---
    @@ -58,7 +58,8 @@ if [ -n "$IPYTHON_OPTS" ]; then
       IPYTHON=1
     fi
     
    -if [[ "$IPYTHON" = "1" ]] ; then
    +# Only use ipython if no command line arguments were provided [SPARK-1134]
    +if [[ "$IPYTHON" = "1" && $# = 0 ]] ; then
       exec ipython $IPYTHON_OPTS
    --- End diff --
    
    If we can, I'd like to remove `IPYTHON_OPTS`, since it makes it a little 
awkward to start the notebook server:
    
    ```
    IPYTHON=1 IPYTHON_OPTS=notebook ./pyspark
    ```
    versus
    
    ```
    IPYTHON=1 ./pyspark notebook
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to