Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/50#discussion_r10201291
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -52,11 +52,21 @@ private class DiskStore(blockManager: BlockManager,
diskManager: DiskBlockManage
val finishTime = System.currentTimeMillis
logDebug("Block %s stored as %s file on disk in %d ms".format(
file.getName, Utils.bytesToString(bytes.limit), (finishTime -
startTime)))
+ return PutResult(bytes.limit(), Right(bytes.duplicate()))
+ }
+
+ override def putValues(
+ blockId: BlockId,
+ values: ArrayBuffer[Any],
+ level: StorageLevel,
+ returnValues: Boolean)
+ : PutResult = {
--- End diff --
The formatting of this parameter list is wrong (sorry, not sure why Jenkins
is not catching this); the proper formatting should be
```
override def putValues(
blockId: BlockId,
values: ArrayBuffer[Any],
level: StorageLevel,
returnValues: Boolean): PutResult =
{
...
}
```
See
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide for
some examples
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
