Github user CodingCat commented on a diff in the pull request:

    https://github.com/apache/spark/pull/44#discussion_r10241868
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -847,6 +847,8 @@ class SparkContext(
           partitions: Seq[Int],
           allowLocal: Boolean,
           resultHandler: (Int, U) => Unit) {
    +    val partitionRange = (0 until rdd.partitions.size)
    +    require(partitions.forall(partitionRange.contains(_)), "partition 
index out of range")
    --- End diff --
    
    two questions
    
    1. Does the Spark guarantee that RDD has continuous partition index? (I 
think so, as https://spark-project.atlassian.net/browse/SPARK-911 is still 
there)
    
    2. Shall we put the check here or we want to check inside the specific 
APIs, (the current issue looks more like a bug in lookup() - forget to check 
the return value of getPartition before using it....) 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to