Github user CodingCat commented on a diff in the pull request:

    https://github.com/apache/spark/pull/85#discussion_r10355799
  
    --- Diff: core/src/main/scala/org/apache/spark/util/AkkaUtils.scala ---
    @@ -108,6 +108,6 @@ private[spark] object AkkaUtils {
     
       /** Returns the default Spark timeout to use for Akka remote actor 
lookup. */
       def lookupTimeout(conf: SparkConf): FiniteDuration = {
    -    Duration.create(conf.get("spark.akka.lookupTimeout", "30").toLong, 
"seconds")
    +    Duration.create(conf.getLong("spark.akka.lookupTimeout", 30), 
"seconds")
    --- End diff --
    
    Oh, when I looked at this parameter I found that it is inconsistent with 
L106, I thought it is better to make them consistent, especially when they are 
so similar in the functionality....
    
    
https://github.com/CodingCat/spark/blob/config_fix/core/src/main/scala/org/apache/spark/util/AkkaUtils.scala#L106
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to