Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/94#issuecomment-36946598
hey @tgravescs good catch on this one.
In terms of abstracting. The most abstract we could do would be to add a
method to a `Partition` called `getPipeEnvVars` or something. That seems maybe
a bit heavyweight since this is just, for now, a single case. An intermediate
thing would be to add `getPipeEnvVars` only to `HadoopPartition` and move the
logic about input split checking to HadoopPartition. That seems slightly nicer
to me and it would leave the door open to bumping that method into the
`Partition` class. What do you think about that? This is just an idea not
really a strong preference.
Small comment about the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
