Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-37213685
Thanks for another round of reviews @mengxr. I will fix these style issues,
answer your comments and add more documentation around the optimizations later
today.
In general, I wonder whether we could add these checks to scalastyle to be
cognizant of the style rules during development. May be we could also update
the scala code style guide to reflect these requirements. For somebody, who
likes consistency but codes in multiple languages/codebases in a day, it's good
to have these forced guidelines for easier development. Also, it reduces the
style-checking during the review which would reduce the burden on the reviewers
as well.
Thanks again for the detailed reviews.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
