Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/126#discussion_r10549710
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
    @@ -1025,6 +1025,14 @@ abstract class RDD[T: ClassTag](
         checkpointData.flatMap(_.getCheckpointFile)
       }
     
    +  def cleanup() {
    --- End diff --
    
    This does not actually cleanup the RDD, but rather just queues it for 
cleanup. At the very least it needs documentation, but from a user's 
standpoint, if they call cleanup(), they may well want it to actually block on 
the cleanup being completed. I can't see a particular case in which correctness 
relies on timely cleanup except for perf testing, though. I also don't see a 
particularly good reason to enqueue the cleanup here except to share the code 
path with the finalizer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to