Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/42#discussion_r10551998
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
    @@ -0,0 +1,93 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.scheduler
    +
    +import org.json4s.jackson.JsonMethods._
    +
    +import org.apache.spark.{Logging, SparkConf}
    +import org.apache.spark.io.CompressionCodec
    +import org.apache.spark.util.{JsonProtocol, FileLogger}
    +
    +/**
    + * A SparkListener that logs events to persistent storage.
    + *
    + * Event logging is specified by the following configurable parameters:
    + *   spark.eventLog.enabled - Whether event logging is enabled.
    + *   spark.eventLog.compress - Whether to compress logged events
    + *   spark.eventLog.overwrite - Whether to overwrite any existing files.
    + *   spark.eventLog.dir - Path to the directory in which events are logged.
    + *   spark.eventLog.buffer.kb - Buffer size to use when writing to output 
streams
    + */
    +private[spark] class EventLoggingListener(appName: String, conf: SparkConf)
    +  extends SparkListener with Logging {
    +
    +  private val shouldCompress = conf.getBoolean("spark.eventLog.compress", 
false)
    +  private val shouldOverwrite = 
conf.getBoolean("spark.eventLog.overwrite", true)
    --- End diff --
    
    I'd set this one to false and actually throw an exception that fails the 
job if the directory already exists (and overwrite is not selected).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to