Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/101#discussion_r10552386
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
    @@ -222,4 +232,27 @@ private[spark] object HadoopRDD {
     
       def putCachedMetadata(key: String, value: Any) =
         SparkEnv.get.hadoopJobMetadata.put(key, value)
    +
    +  /**
    +   *
    +   * @param jtId
    +   * @param jobId
    +   * @param splitId
    +   * @param attemptId
    +   * @param conf
    +   */
    +  def addLocalConfiguration(jtId: String, jobId: Int, splitId: Int, 
attemptId: Int,
    --- End diff --
    
    This method almost looks like it's incomplete - would you mind changing 
jtId to jobTrackerId, update the method comment, and remove the commented lines 
here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to