Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/147#discussion_r10636474
  
    --- Diff: core/src/main/scala/org/apache/spark/util/AkkaUtils.scala ---
    @@ -121,4 +121,9 @@ private[spark] object AkkaUtils extends Logging {
       def lookupTimeout(conf: SparkConf): FiniteDuration = {
         Duration.create(conf.get("spark.akka.lookupTimeout", "30").toLong, 
"seconds")
       }
    +
    +  /** Returns the default max frame size for Akka messages in MB. */
    +  def maxFrameSize(conf: SparkConf): Int = {
    --- End diff --
    
    So one idea - why not make this `maxFrameSizeBytes` (i.e. do the byte 
conversion inside of here) and also use the same code inside of 
`Executor.scala` in place of the thing that's there now. Then we have a single 
code path for doing this every time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to