Hey Nicholas, That seems promising - I prefer having a proper link to having that fairly verbose comment though, because in some cases there will be dozens of comments and it could get lost. I wonder if they could do something where it posts a link instead...
- Patrick On Mon, Aug 25, 2014 at 11:06 AM, Nicholas Chammas < nicholas.cham...@gmail.com> wrote: > FYI: Looks like the Mesos folk also have a bot to do automatic linking, > but it appears to have been provided to them somehow by ASF. > > See this comment as an example: > https://issues.apache.org/jira/browse/MESOS-1688?focusedCommentId=14109078&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14109078 > > Might be a small win to push this work to a bot ASF manages if we can get > access to it (and if we have no concerns about depending on an another > external service). > > Nick > > > On Mon, Aug 11, 2014 at 4:10 PM, Nicholas Chammas < > nicholas.cham...@gmail.com> wrote: > >> Thanks for looking into this. I think little tools like this are super >> helpful. >> >> Would it hurt to open a request with INFRA to install/configure the >> JIRA-GitHub plugin while we continue to use the Python script we have? I >> wouldn't mind opening that JIRA issue with them. >> >> Nick >> >> >> On Mon, Aug 11, 2014 at 12:52 PM, Patrick Wendell <pwend...@gmail.com> >> wrote: >> >>> I spent some time on this and I'm not sure either of these is an option, >>> unfortunately. >>> >>> We typically can't use custom JIRA plug-in's because this JIRA is >>> controlled by the ASF and we don't have rights to modify most things about >>> how it works (it's a large shared JIRA instance used by more than 50 >>> projects). It's worth looking into whether they can do something. In >>> general we've tended to avoid going through ASF infra them whenever >>> possible, since they are generally overloaded and things move very slowly, >>> even if there are outages. >>> >>> Here is the script we use to do the sync: >>> https://github.com/apache/spark/blob/master/dev/github_jira_sync.py >>> >>> It might be possible to modify this to support post-hoc changes, but >>> we'd need to think about how to do so while minimizing function calls to >>> the ASF JIRA API, which I found are very slow. >>> >>> - Patrick >>> >>> >>> >>> On Mon, Aug 11, 2014 at 7:51 AM, Nicholas Chammas < >>> nicholas.cham...@gmail.com> wrote: >>> >>>> It looks like this script doesn't catch PRs that are opened and *then* >>>> have >>>> >>>> the JIRA issue ID added to the name. Would it be easy to somehow have >>>> the >>>> script trigger on PR name changes as well as PR creates? >>>> >>>> Alternately, is there a reason we can't or don't want to use the plugin >>>> mentioned below? (I'm assuming it covers cases like this, but I'm not >>>> sure.) >>>> >>>> Nick >>>> >>>> >>>> >>>> On Wed, Jul 23, 2014 at 12:52 PM, Nicholas Chammas < >>>> nicholas.cham...@gmail.com> wrote: >>>> >>>> > By the way, it looks like there's a JIRA plugin that integrates it >>>> with >>>> > GitHub: >>>> > >>>> > - >>>> > >>>> https://marketplace.atlassian.com/plugins/com.atlassian.jira.plugins.jira-bitbucket-connector-plugin >>>> >>>> > - >>>> > >>>> https://confluence.atlassian.com/display/BITBUCKET/Linking+Bitbucket+and+GitHub+accounts+to+JIRA >>>> > >>>> > It does the automatic linking and shows some additional information >>>> > < >>>> https://marketplace-cdn.atlassian.com/files/images/com.atlassian.jira.plugins.jira-bitbucket-connector-plugin/86ff1a21-44fb-4227-aa4f-44c77aec2c97.png >>>> > >>>> >>>> > that might be nice to have for heavy JIRA users. >>>> > >>>> > Nick >>>> > >>>> > >>>> > >>>> > On Sun, Jul 20, 2014 at 12:50 PM, Patrick Wendell <pwend...@gmail.com >>>> > >>>> > wrote: >>>> > >>>> >> Yeah it needs to have SPARK-XXX in the title (this is the format we >>>> >> request already). It just works with small synchronization script I >>>> >> wrote that we run every five minutes on Jeknins that uses the Github >>>> >> and Jenkins API: >>>> >> >>>> >> >>>> >> >>>> https://github.com/apache/spark/commit/49e472744951d875627d78b0d6e93cd139232929 >>>> >> >>>> >> - Patrick >>>> >> >>>> >> On Sun, Jul 20, 2014 at 8:06 AM, Nicholas Chammas >>>> >> <nicholas.cham...@gmail.com> wrote: >>>> >> > That's pretty neat. >>>> >> > >>>> >> > How does it work? Do we just need to put the issue ID (e.g. >>>> SPARK-1234) >>>> >> > anywhere in the pull request? >>>> >> > >>>> >> > Nick >>>> >> > >>>> >> > >>>> >> > On Sat, Jul 19, 2014 at 11:10 PM, Patrick Wendell < >>>> pwend...@gmail.com> >>>> >> > wrote: >>>> >> > >>>> >> >> Just a small note, today I committed a tool that will >>>> automatically >>>> >> >> mirror pull requests to JIRA issues, so contributors will no >>>> longer >>>> >> >> have to manually post a pull request on the JIRA when they make >>>> one. >>>> >> >> >>>> >> >> It will create a "link" on the JIRA and also make a comment to >>>> trigger >>>> >> >> an e-mail to people watching. >>>> >> >> >>>> >> >> This should make some things easier, such as avoiding accidental >>>> >> >> duplicate effort on the same JIRA. >>>> >> >> >>>> >> >> - Patrick >>>> >> >> >>>> >> >>>> > >>>> > >>>> >>> >>> >> >