How early can MiMa checks be run? Before Spark is even built <https://github.com/apache/spark/blob/8cc70e7e15fd800f31b94e9102069506360289db/dev/run-tests#L118>? After the build but before the unit tests?
On Thu, Sep 25, 2014 at 6:06 PM, Patrick Wendell <pwend...@gmail.com> wrote: > Yeah we can also move it first. Wouldn't hurt. > > On Thu, Sep 25, 2014 at 6:39 AM, Nicholas Chammas > <nicholas.cham...@gmail.com> wrote: > > It might still make sense to make this change if MIMA checks are always > > relatively quick, for the same reason we do style checks first. > > > > On Thu, Sep 25, 2014 at 12:25 AM, Nan Zhu <zhunanmcg...@gmail.com> > wrote: > >> > >> yeah, I tried that, but there is always an issue when I ran dev/mima, > >> > >> it always gives me some binary compatibility error on Java API part.... > >> > >> so I have to wait for Jenkins' result when fixing MIMA issues > >> > >> -- > >> Nan Zhu > >> > >> > >> On Thursday, September 25, 2014 at 12:04 AM, Patrick Wendell wrote: > >> > >> > Have you considered running the mima checks locally? We prefer people > >> > not use Jenkins for very frequent checks since it takes resources away > >> > from other people trying to run tests. > >> > > >> > On Wed, Sep 24, 2014 at 6:44 PM, Nan Zhu <zhunanmcg...@gmail.com > >> > (mailto:zhunanmcg...@gmail.com)> wrote: > >> > > Hi, all > >> > > > >> > > It seems that, currently, Jenkins makes MIMA checking after all test > >> > > cases have finished, IIRC, during the first months we introduced > MIMA, we do > >> > > the MIMA checking before running test cases > >> > > > >> > > What's the motivation to adjust this behaviour? > >> > > > >> > > In my opinion, if you have some binary compatibility issues, you > just > >> > > need to do some minor changes, but in the current environment, you > can only > >> > > get if your change works after all test cases finished (1 hour > later...) > >> > > > >> > > Best, > >> > > > >> > > -- > >> > > Nan Zhu > >> > > > >> > > >> > > >> > > >> > >> > > >
