You only need to rebase if your branch/PR now conflicts with master.
you don't need to squash since the merge script will do that in the
end for you. You can squash commits and force-push if you think it
would help clean up your intent, but, often it's clearer to leave the
review and commit history of your branch since the review comments go
along with it.

On Tue, Jul 28, 2015 at 9:46 PM, Meihua Wu <rotationsymmetr...@gmail.com> wrote:
> I am planning to update my PR to incorporate comments from reviewers.
> Do I need to rebase/squash the commits into a single one?
>
> Thanks!
>
> -MW
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@spark.apache.org
> For additional commands, e-mail: dev-h...@spark.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@spark.apache.org
For additional commands, e-mail: dev-h...@spark.apache.org

Reply via email to