Hey Pete, I just pushed your PR to branch 1.6. As it's not a blocker, it may or may not be in 1.6.2, depending on if there will be another RC.
On Tue, Jun 21, 2016 at 1:36 PM, Pete Robbins <robbin...@gmail.com> wrote: > It breaks Spark running on machines with less than 3 cores/threads, which > may be rare, and it is maybe an edge case. > > Personally, I like to fix known bugs and the fact there are other blocking > methods in event loops actually makes it worse not to fix ones that you > know about. > > Probably not a blocker to release though but that's your call. > > Cheers, > > On Tue, Jun 21, 2016 at 6:40 PM Shixiong(Ryan) Zhu < > shixi...@databricks.com> wrote: > >> Hey Pete, >> >> I didn't backport it to 1.6 because it just affects tests in most cases. >> I'm sure we also have other places calling blocking methods in the event >> loops, so similar issues are still there even after applying this patch. >> Hence, I don't think it's a blocker for 1.6.2. >> >> On Tue, Jun 21, 2016 at 2:57 AM, Pete Robbins <robbin...@gmail.com> >> wrote: >> >>> The PR (https://github.com/apache/spark/pull/13055) to fix >>> https://issues.apache.org/jira/browse/SPARK-15262 was applied to 1.6.2 >>> however this fix caused another issue >>> https://issues.apache.org/jira/browse/SPARK-15606 the fix for which ( >>> https://github.com/apache/spark/pull/13355) has not been backported to >>> the 1.6 branch so I'm now seeing the same failure in 1.6.2 >>> >>> Cheers, >>> >>> On Mon, 20 Jun 2016 at 05:25 Reynold Xin <r...@databricks.com> wrote: >>> >>>> Please vote on releasing the following candidate as Apache Spark >>>> version 1.6.2. The vote is open until Wednesday, June 22, 2016 at 22:00 PDT >>>> and passes if a majority of at least 3+1 PMC votes are cast. >>>> >>>> [ ] +1 Release this package as Apache Spark 1.6.2 >>>> [ ] -1 Do not release this package because ... >>>> >>>> >>>> The tag to be voted on is v1.6.2-rc2 >>>> (54b1121f351f056d6b67d2bb4efe0d553c0f7482) >>>> >>>> The release files, including signatures, digests, etc. can be found at: >>>> http://people.apache.org/~pwendell/spark-releases/spark-1.6.2-rc2-bin/ >>>> >>>> Release artifacts are signed with the following key: >>>> https://people.apache.org/keys/committer/pwendell.asc >>>> >>>> The staging repository for this release can be found at: >>>> https://repository.apache.org/content/repositories/orgapachespark-1186/ >>>> >>>> The documentation corresponding to this release can be found at: >>>> http://people.apache.org/~pwendell/spark-releases/spark-1.6.2-rc2-docs/ >>>> >>>> >>>> ======================================= >>>> == How can I help test this release? == >>>> ======================================= >>>> If you are a Spark user, you can help us test this release by taking an >>>> existing Spark workload and running on this release candidate, then >>>> reporting any regressions from 1.6.1. >>>> >>>> ================================================ >>>> == What justifies a -1 vote for this release? == >>>> ================================================ >>>> This is a maintenance release in the 1.6.x series. Bugs already >>>> present in 1.6.1, missing features, or bugs related to new features will >>>> not necessarily block this release. >>>> >>>> >>>> >>>> >>
