Yes - same thing with children in UnaryExpression, BinaryExpression. Although I have to say the utility isn't that big here.
On Tue, Sep 27, 2016 at 12:53 AM, Jacek Laskowski <ja...@japila.pl> wrote: > Hi, > > Perhaps nitpicking...you've been warned. > > While reviewing expressions in Catalyst I've noticed some > inconsistency, i.e. Nondeterministic trait has two methods > deterministic and foldable final override while LeafExpression does > not have children final (at the very least). > > My thinking is that LeafExpression is to mark left expressions so > children is assumed to be Nil. > > Should children be final in LeafExpression? Why not? #curious > > Pozdrawiam, > Jacek Laskowski > ---- > https://medium.com/@jaceklaskowski/ > Mastering Apache Spark 2.0 http://bit.ly/mastering-apache-spark > Follow me at https://twitter.com/jaceklaskowski > > --------------------------------------------------------------------- > To unsubscribe e-mail: dev-unsubscr...@spark.apache.org > >
