private[sql] has no impact in Java, and these functions are literally one line of code. It's overkill to think about code duplication for functions that simple.
On Fri, Nov 11, 2016 at 1:12 PM, Jacek Laskowski <ja...@japila.pl> wrote: > Hi, > > Any reason for withExpr duplication in Column [1] and functions [2] > objects? It looks like it could be less private and be at least > private[sql]? > > private def withExpr(newExpr: Expression): Column = new Column(newExpr) > > [1] https://github.com/apache/spark/blob/master/sql/core/ > src/main/scala/org/apache/spark/sql/Column.scala#L152 > [2] https://github.com/apache/spark/blob/master/sql/core/ > src/main/scala/org/apache/spark/sql/functions.scala#L60 > > Pozdrawiam, > Jacek Laskowski > ---- > https://medium.com/@jaceklaskowski/ > Mastering Apache Spark 2.0 https://bit.ly/mastering-apache-spark > Follow me at https://twitter.com/jaceklaskowski > > --------------------------------------------------------------------- > To unsubscribe e-mail: dev-unsubscr...@spark.apache.org > >
