+1 (non-binding) On Wed, Jul 18, 2018 at 10:38 AM Denny Lee <denny.g....@gmail.com> wrote:
> +1 (non-binding) > On Tue, Jul 17, 2018 at 23:04 John Zhuge <jzh...@apache.org> wrote: > >> +1 (non-binding) >> >> On Mon, Jul 16, 2018 at 8:04 PM Saisai Shao <sai.sai.s...@gmail.com> >> wrote: >> >>> I will put my +1 on this RC. >>> >>> For the test failure fix, I will include it if there's another RC. >>> >>> Sean Owen <sro...@apache.org> 于2018年7月16日周一 下午10:47写道： >>> >> OK, hm, will try to get to the bottom of it. But if others can build this >>>> module successfully, I give a +1 . The test failure is inevitable here and >>>> should not block release. >>>> >>>> On Sun, Jul 15, 2018 at 9:39 PM Saisai Shao <sai.sai.s...@gmail.com> >>>> wrote: >>>> >>> Hi Sean, >>>>> >>>>> I just did a clean build with mvn/sbt on 2.3.2, I didn't meet the >>>>> errors you pasted here. I'm not sure how it happens. >>>>> >>>>> Sean Owen <sro...@apache.org> 于2018年7月16日周一 上午6:30写道： >>>>> >>>> Looks good to me, with the following caveats. >>>>>> >>>>>> First see the discussion on >>>>>> https://issues.apache.org/jira/browse/SPARK-24813 ; the >>>>>> flaky HiveExternalCatalogVersionsSuite will probably fail all the time >>>>>> right now. That's not a regression and is a test-only issue, so don't >>>>>> think >>>>>> it must block the release. However if this fix holds up, and we need >>>>>> another RC, worth pulling in for sure. >>>>>> >>>>>> Also is anyone seeing this while building and testing the Spark SQL + >>>>>> Kafka module? I see this error even after a clean rebuild. I sort of get >>>>>> what the error is saying but can't figure out why it would only happen at >>>>>> test/runtime. Haven't seen it before. >>>>>> >>>>>> [error] missing or invalid dependency detected while loading class >>>>>> file 'MetricsSystem.class'. >>>>>> >>>>>> [error] Could not access term eclipse in package org, >>>>>> >>>>>> [error] because it (or its dependencies) are missing. Check your >>>>>> build definition for >>>>>> >>>>>> [error] missing or conflicting dependencies. (Re-run with >>>>>> `-Ylog-classpath` to see the problematic classpath.) >>>>>> >>>>>> [error] A full rebuild may help if 'MetricsSystem.class' was compiled >>>>>> against an incompatible version of org. >>>>>> >>>>>> [error] missing or invalid dependency detected while loading class >>>>>> file 'MetricsSystem.class'. >>>>>> >>>>>> [error] Could not access term jetty in value org.eclipse, >>>>>> >>>>>> [error] because it (or its dependencies) are missing. Check your >>>>>> build definition for >>>>>> >>>>>> [error] missing or conflicting dependencies. (Re-run with >>>>>> `-Ylog-classpath` to see the problematic classpath.) >>>>>> >>>>>> [error] A full rebuild may help if 'MetricsSystem.class' was compiled >>>>>> against an incompatible version of org.eclipse >>>>>> >>>>>> On Sun, Jul 15, 2018 at 3:09 AM Saisai Shao <sai.sai.s...@gmail.com> >>>>>> wrote: >>>>>> >>>>> Please vote on releasing the following candidate as Apache Spark >>>>>>> version 2.3.2. >>>>>>> >>>>>>> The vote is open until July 20 PST and passes if a majority +1 PMC >>>>>>> votes are cast, with a minimum of 3 +1 votes. >>>>>>> >>>>>>> [ ] +1 Release this package as Apache Spark 2.3.2 >>>>>>> [ ] -1 Do not release this package because ... >>>>>>> >>>>>>> To learn more about Apache Spark, please see >>>>>>> http://spark.apache.org/ >>>>>>> >>>>>>> The tag to be voted on is v2.3.2-rc3 >>>>>>> (commit b3726dadcf2997f20231873ec6e057dba433ae64): >>>>>>> https://github.com/apache/spark/tree/v2.3.2-rc3 >>>>>>> >>>>>>> The release files, including signatures, digests, etc. can be found >>>>>>> at: >>>>>>> https://dist.apache.org/repos/dist/dev/spark/v2.3.2-rc3-bin/ >>>>>>> >>>>>>> Signatures used for Spark RCs can be found in this file: >>>>>>> https://dist.apache.org/repos/dist/dev/spark/KEYS >>>>>>> >>>>>>> The staging repository for this release can be found at: >>>>>>> >>>>>>> https://repository.apache.org/content/repositories/orgapachespark-1278/ >>>>>>> >>>>>>> The documentation corresponding to this release can be found at: >>>>>>> https://dist.apache.org/repos/dist/dev/spark/v2.3.2-rc3-docs/ >>>>>>> >>>>>>> The list of bug fixes going into 2.3.2 can be found at the following >>>>>>> URL: >>>>>>> https://issues.apache.org/jira/projects/SPARK/versions/12343289 >>>>>>> >>>>>>> Note. RC2 was cancelled because of one blocking issue SPARK-24781 >>>>>>> during release preparation. >>>>>>> >>>>>>> FAQ >>>>>>> >>>>>>> ========================= >>>>>>> How can I help test this release? >>>>>>> ========================= >>>>>>> >>>>>>> If you are a Spark user, you can help us test this release by taking >>>>>>> an existing Spark workload and running on this release candidate, >>>>>>> then >>>>>>> reporting any regressions. >>>>>>> >>>>>>> If you're working in PySpark you can set up a virtual env and install >>>>>>> the current RC and see if anything important breaks, in the >>>>>>> Java/Scala >>>>>>> you can add the staging repository to your projects resolvers and >>>>>>> test >>>>>>> with the RC (make sure to clean up the artifact cache before/after so >>>>>>> you don't end up building with a out of date RC going forward). >>>>>>> >>>>>>> =========================================== >>>>>>> What should happen to JIRA tickets still targeting 2.3.2? >>>>>>> =========================================== >>>>>>> >>>>>>> The current list of open tickets targeted at 2.3.2 can be found at: >>>>>>> https://issues.apache.org/jira/projects/SPARK and search for "Target >>>>>>> Version/s" = 2.3.2 >>>>>>> >>>>>>> Committers should look at those and triage. Extremely important bug >>>>>>> fixes, documentation, and API tweaks that impact compatibility should >>>>>>> be worked on immediately. Everything else please retarget to an >>>>>>> appropriate release. >>>>>>> >>>>>>> ================== >>>>>>> But my bug isn't fixed? >>>>>>> ================== >>>>>>> >>>>>>> In order to make timely releases, we will typically not hold the >>>>>>> release unless the bug in question is a regression from the previous >>>>>>> release. That being said, if there is something which is a regression >>>>>>> that has not been correctly targeted please ping me or a committer to >>>>>>> >>>>>> help target the issue. >>>>>>> >>>>>> >>>>>>> >>>>>>> -- >>>>>>> John Zhuge >>>>>>> >>>>>> -- Ryan Blue Software Engineer Netflix
