I agree with Imran on this. Since we are already on rc8, we don't want to indefinitely hold the release for one more fix, but it this one is a severe deadlock.
Note to myself and other community members: May be we can be more proactive in checking and reporting inprogress PR reviews/JIRAs for any blockers as early or as soon as the first RC is cut, so that we don't hold the release process. I believe in this case, the merge commit and RC were in a very close time frame. On Wed, Mar 20, 2019 at 11:32 AM Imran Rashid <im...@therashids.com> wrote: > Even if only PMC are able to veto a release, I believe all community > members are encouraged to vote, even a -1, to express their opinions, right? > > I am -0.5 on the release because of SPARK-27112. It is not a regression, > so in that sense I don't think it must hold the release. But it is fixing > a pretty bad deadlock. > > that said, I'm only -0.5 because (a) I don't want to keep holding the > release indefinitely for "one more fix" and (b) this will probably only hit > users running on large clusters -- probably sophisticated enough users to > apply their own set of patches. I'd prefer we cut another rc with the fix, > but understand the tradeoffs here. > > On Wed, Mar 20, 2019 at 10:17 AM Sean Owen <sro...@gmail.com> wrote: > >> Is it a regression from 2.4.0? that's not the only criteria but part of >> it. >> The version link is >> https://issues.apache.org/jira/projects/SPARK/versions/12344117 >> >> On Wed, Mar 20, 2019 at 10:15 AM dhruve ashar <dhruveas...@gmail.com> >> wrote: >> >>> A deadlock bug was recently fixed and backported to 2.4, but the rc was >>> cut before that. I think we should include a critical bug like that in the >>> current rc. >>> >>> issue: https://issues.apache.org/jira/browse/SPARK-27112 >>> commit: >>> https://github.com/apache/spark/commit/95e73b328ac883be2ced9099f20c8878e498e297 >>> >>> I am hitting a deadlink while checking: >>> https://issues.apache.org/jira/projects/SPARK/versions/2.4.1 >>> I don't know what the right url looks like, but we should fix it. >>> >>> On Wed, Mar 20, 2019 at 9:14 AM Stavros Kontopoulos < >>> stavros.kontopou...@lightbend.com> wrote: >>> >>>> +1 (non-binding) >>>> >>>> On Wed, Mar 20, 2019 at 8:33 AM Sean Owen <sro...@gmail.com> wrote: >>>> >>>>> (Only the PMC can veto a release) >>>>> That doesn't look like a regression. I get that it's important, but I >>>>> don't see that it should block this release. >>>>> >>>>> On Tue, Mar 19, 2019 at 11:00 PM Darcy Shen <sad...@zoho.com.invalid> >>>>> wrote: >>>>> > >>>>> > -1 >>>>> > >>>>> > please backpoart SPARK-27160, a correctness issue about ORC native >>>>> reader. >>>>> > >>>>> > see https://github.com/apache/spark/pull/24092 >>>>> > >>>>> > >>>>> > ---- On Wed, 20 Mar 2019 06:21:29 +0800 DB Tsai >>>>> <d_t...@apple.com.INVALID> wrote ---- >>>>> > >>>>> > Please vote on releasing the following candidate as Apache Spark >>>>> version 2.4.1. >>>>> > >>>>> > The vote is open until March 23 PST and passes if a majority +1 PMC >>>>> votes are cast, with >>>>> > a minimum of 3 +1 votes. >>>>> > >>>>> > [ ] +1 Release this package as Apache Spark 2.4.1 >>>>> > [ ] -1 Do not release this package because ... >>>>> > >>>>> > To learn more about Apache Spark, please see >>>>> http://spark.apache.org/ >>>>> > >>>>> > The tag to be voted on is v2.4.1-rc8 (commit >>>>> 746b3ddee6f7ad3464e326228ea226f5b1f39a41): >>>>> > https://github.com/apache/spark/tree/v2.4.1-rc8 >>>>> > >>>>> > The release files, including signatures, digests, etc. can be found >>>>> at: >>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.4.1-rc8-bin/ >>>>> > >>>>> > Signatures used for Spark RCs can be found in this file: >>>>> > https://dist.apache.org/repos/dist/dev/spark/KEYS >>>>> > >>>>> > The staging repository for this release can be found at: >>>>> > >>>>> https://repository.apache.org/content/repositories/orgapachespark-1318/ >>>>> > >>>>> > The documentation corresponding to this release can be found at: >>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.4.1-rc8-docs/ >>>>> > >>>>> > The list of bug fixes going into 2.4.1 can be found at the following >>>>> URL: >>>>> > https://issues.apache.org/jira/projects/SPARK/versions/2.4.1 >>>>> > >>>>> > FAQ >>>>> > >>>>> > ========================= >>>>> > How can I help test this release? >>>>> > ========================= >>>>> > >>>>> > If you are a Spark user, you can help us test this release by taking >>>>> > an existing Spark workload and running on this release candidate, >>>>> then >>>>> > reporting any regressions. >>>>> > >>>>> > If you're working in PySpark you can set up a virtual env and install >>>>> > the current RC and see if anything important breaks, in the >>>>> Java/Scala >>>>> > you can add the staging repository to your projects resolvers and >>>>> test >>>>> > with the RC (make sure to clean up the artifact cache before/after so >>>>> > you don't end up building with a out of date RC going forward). >>>>> > >>>>> > =========================================== >>>>> > What should happen to JIRA tickets still targeting 2.4.1? >>>>> > =========================================== >>>>> > >>>>> > The current list of open tickets targeted at 2.4.1 can be found at: >>>>> > https://issues.apache.org/jira/projects/SPARK and search for >>>>> "Target Version/s" = 2.4.1 >>>>> > >>>>> > Committers should look at those and triage. Extremely important bug >>>>> > fixes, documentation, and API tweaks that impact compatibility should >>>>> > be worked on immediately. Everything else please retarget to an >>>>> > appropriate release. >>>>> > >>>>> > ================== >>>>> > But my bug isn't fixed? >>>>> > ================== >>>>> > >>>>> > In order to make timely releases, we will typically not hold the >>>>> > release unless the bug in question is a regression from the previous >>>>> > release. That being said, if there is something which is a regression >>>>> > that has not been correctly targeted please ping me or a committer to >>>>> > help target the issue. >>>>> > >>>>> > >>>>> > DB Tsai | Siri Open Source Technologies [not a contribution] | >>>>> Apple, Inc >>>>> > >>>>> > >>>>> > --------------------------------------------------------------------- >>>>> > To unsubscribe e-mail: dev-unsubscr...@spark.apache.org >>>>> > >>>>> > >>>>> > >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe e-mail: dev-unsubscr...@spark.apache.org >>>>> >>>>> >>>> >>>> -- >>>> Stavros Kontopoulos >>>> >>>> *Senior Software Engineer* >>>> *Lightbend, Inc.* >>>> >>>> *p: +30 6977967274 <%2B1%20650%20678%200020>* >>>> *e: stavros.kontopou...@lightbend.com* <dave.mar...@lightbend.com> >>>> >>>> >>>> >>> >>> -- >>> -Dhruve Ashar >>> >>> -- -Dhruve Ashar
