// Fixing Subject Results of the voting:
Binding +1s: 5 (Tom Graves, Dongjoon Hyun, Felix Cheung, Saisai Shao, Imran Rashid) Non-Binding +1s: 8 -1 from PMC members: 0 Per PMC / SPIP Voting Rules (https://spark.apache.org/improvement-proposals.html [spark.apache.org]<https://urldefense.proofpoint.com/v2/url?u=https-3A__spark.apache.org_improvement-2Dproposals.html&d=DwMGaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=7WzLIMu3WvZwd6AMPatqn1KZW39eI6c_oflAHIy1NUc&m=1EZK-YO5oN-zPv6WLMN0vMQkt3jYWh_hx9x1GUO_w7Q&s=u9r4Ne1QOoZWgt2AteJC56yxhZ0v1VfXBH9Zg4s_Eyc&e=>), given that the vote has been open for >72 hours and 3 +1 binding votes have been received, this SPIP passes. Thanks everyone. From: Vinoo Ganesh <[email protected]> Date: Friday, June 21, 2019 at 13:44 To: Tom Graves <[email protected]>, dhruve ashar <[email protected]>, John Zhuge <[email protected]>, "Guo, Chenzhao" <[email protected]> Cc: Felix Cheung <[email protected]>, Yinan Li <[email protected]>, "[email protected]" <[email protected]>, Dongjoon Hyun <[email protected]>, Saisai Shao <[email protected]>, Imran Rashid <[email protected]>, Ilan Filonenko <[email protected]>, bo yang <[email protected]>, Matt Cheah <[email protected]>, Spark Dev List <[email protected]>, "Yifei Huang (PD)" <[email protected]>, Imran Rashid <[email protected]> Subject: Re: [VOTE][SPARK-25299] SPIP: Shuffle Storage API Results of the voting: Binding +1s: 5 (Tom Graves, Dongjoon Hyun, Felix Cheung, Saisai Shao, Imran Rashid) Non-Binding +1s: 8 -1 from PMC members: 0 Per PMC / SPIP Voting Rules (https://spark.apache.org/improvement-proposals.html [spark.apache.org]<https://urldefense.proofpoint.com/v2/url?u=https-3A__spark.apache.org_improvement-2Dproposals.html&d=DwMGaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=7WzLIMu3WvZwd6AMPatqn1KZW39eI6c_oflAHIy1NUc&m=1EZK-YO5oN-zPv6WLMN0vMQkt3jYWh_hx9x1GUO_w7Q&s=u9r4Ne1QOoZWgt2AteJC56yxhZ0v1VfXBH9Zg4s_Eyc&e=>), given that the vote has been open for >72 hours and 3 +1 binding votes have been received, this SPIP passes. Thanks everyone. From: Tom Graves <[email protected]> Date: Friday, June 21, 2019 at 13:02 To: dhruve ashar <[email protected]>, John Zhuge <[email protected]>, "Guo, Chenzhao" <[email protected]> Cc: Vinoo Ganesh <[email protected]>, Felix Cheung <[email protected]>, Yinan Li <[email protected]>, "[email protected]" <[email protected]>, Dongjoon Hyun <[email protected]>, Saisai Shao <[email protected]>, Imran Rashid <[email protected]>, Ilan Filonenko <[email protected]>, bo yang <[email protected]>, Matt Cheah <[email protected]>, Spark Dev List <[email protected]>, "Yifei Huang (PD)" <[email protected]>, Imran Rashid <[email protected]> Subject: Re: [VOTE][SPARK-25299] SPIP: Shuffle Storage API +1 (binding) I haven't looked at the low level api, but like the idea and approach to get it started. Tom On Tuesday, June 18, 2019, 10:40:34 PM CDT, Guo, Chenzhao <[email protected]> wrote: Cool : ) +1 (non-binding) Chenzhao From: dhruve ashar [mailto:[email protected]] Sent: Wednesday, June 19, 2019 2:58 AM To: John Zhuge <[email protected]> Cc: Vinoo Ganesh <[email protected]>; Felix Cheung <[email protected]>; Yinan Li <[email protected]>; [email protected]; Dongjoon Hyun <[email protected]>; Saisai Shao <[email protected]>; Imran Rashid <[email protected]>; Ilan Filonenko <[email protected]>; bo yang <[email protected]>; Matt Cheah <[email protected]>; Spark Dev List <[email protected]>; Yifei Huang (PD) <[email protected]>; Imran Rashid <[email protected]> Subject: Re: [VOTE][SPARK-25299] SPIP: Shuffle Storage API +1 (non-binding) On Tue, Jun 18, 2019 at 12:12 PM John Zhuge <[email protected]<mailto:[email protected]>> wrote: +1 (non-binding) Great work! On Tue, Jun 18, 2019 at 6:22 AM Vinoo Ganesh <[email protected]<mailto:[email protected]>> wrote: +1 (non-binding). Thanks for pushing this forward, Matt and Yifei. From: Felix Cheung <[email protected]<mailto:[email protected]>> Date: Tuesday, June 18, 2019 at 00:01 To: Yinan Li <[email protected]<mailto:[email protected]>>, "[email protected]<mailto:[email protected]>" <[email protected]<mailto:[email protected]>> Cc: Dongjoon Hyun <[email protected]<mailto:[email protected]>>, Saisai Shao <[email protected]<mailto:[email protected]>>, Imran Rashid <[email protected]<mailto:[email protected]>>, Ilan Filonenko <[email protected]<mailto:[email protected]>>, bo yang <[email protected]<mailto:[email protected]>>, Matt Cheah <[email protected]<mailto:[email protected]>>, Spark Dev List <[email protected]<mailto:[email protected]>>, "Yifei Huang (PD)" <[email protected]<mailto:[email protected]>>, Vinoo Ganesh <[email protected]<mailto:[email protected]>>, Imran Rashid <[email protected]<mailto:[email protected]>> Subject: Re: [VOTE][SPARK-25299] SPIP: Shuffle Storage API +1 Glad to see the progress in this space - it’s been more than a year since the original discussion and effort started. ________________________________ From: Yinan Li <[email protected]<mailto:[email protected]>> Sent: Monday, June 17, 2019 7:14:42 PM To: [email protected]<mailto:[email protected]> Cc: Dongjoon Hyun; Saisai Shao; Imran Rashid; Ilan Filonenko; bo yang; Matt Cheah; Spark Dev List; Yifei Huang (PD); Vinoo Ganesh; Imran Rashid Subject: Re: [VOTE][SPARK-25299] SPIP: Shuffle Storage API +1 (non-binding) On Mon, Jun 17, 2019 at 1:58 PM Ryan Blue <[email protected]<mailto:[email protected]>> wrote: +1 (non-binding) On Sun, Jun 16, 2019 at 11:11 PM Dongjoon Hyun <[email protected]<mailto:[email protected]>> wrote: +1 Bests, Dongjoon. On Sun, Jun 16, 2019 at 9:41 PM Saisai Shao <[email protected]<mailto:[email protected]>> wrote: +1 (binding) Thanks Saisai Imran Rashid <[email protected]<mailto:[email protected]>> 于2019年6月15日周六 上午3:46写道： +1 (binding) I think this is a really important feature for spark. First, there is already a lot of interest in alternative shuffle storage in the community. There is already a lot of interest in alternative shuffle storage, from dynamic allocation in kubernetes, to even just improving stability in standard on-premise use of Spark. However, they're often stuck doing this in forks of Spark, and in ways that are not maintainable (because they copy-paste many spark internals) or are incorrect (for not correctly handling speculative execution & stage retries). Second, I think the specific proposal is good for finding the right balance between flexibility and too much complexity, to allow incremental improvements. A lot of work has been put into this already to try to figure out which pieces are essential to make alternative shuffle storage implementations feasible. Of course, that means it doesn't include everything imaginable; some things still aren't supported, and some will still choose to use the older ShuffleManager api to give total control over all of shuffle. But we know there are a reasonable set of things which can be implemented behind the api as the first step, and it can continue to evolve. On Fri, Jun 14, 2019 at 12:13 PM Ilan Filonenko <[email protected]<mailto:[email protected]>> wrote: +1 (non-binding). This API is versatile and flexible enough to handle Bloomberg's internal use-cases. The ability for us to vary implementation strategies is quite appealing. It is also worth to note the minimal changes to Spark core in order to make it work. This is a very much needed addition within the Spark shuffle story. On Fri, Jun 14, 2019 at 9:59 AM bo yang <[email protected]<mailto:[email protected]>> wrote: +1 This is great work, allowing plugin of different sort shuffle write/read implementation! Also great to see it retain the current Spark configuration (spark.shuffle.manager=org.apache.spark.shuffle.YourShuffleManagerImpl). On Thu, Jun 13, 2019 at 2:58 PM Matt Cheah <[email protected]<mailto:[email protected]>> wrote: Hi everyone, I would like to call a vote for the SPIP for SPARK-25299 [issues.apache.org]<https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_SPARK-2D25299&d=DwMFJg&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=7WzLIMu3WvZwd6AMPatqn1KZW39eI6c_oflAHIy1NUc&m=UG2t14gfU8QHfoj4tUD__9bIVg1xxTM3R8GHmvMUXTU&s=LS6AKX38P5DW6ffk9u5MUvRBEAlAHiA3Ud2KODpWkQU&e=>, which proposes to introduce a pluggable storage API for temporary shuffle data. You may find the SPIP document here [docs.google.com]<https://urldefense.proofpoint.com/v2/url?u=https-3A__docs.google.com_document_d_1d6egnL6WHOwWZe8MWv3m8n4PToNacdx7n-5F0iMSWwhCQ_edit&d=DwMFJg&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=7WzLIMu3WvZwd6AMPatqn1KZW39eI6c_oflAHIy1NUc&m=UG2t14gfU8QHfoj4tUD__9bIVg1xxTM3R8GHmvMUXTU&s=rCSgQGD6L4of4oa0QxiTJ8IPaVdGlZVarhA4-QvO80Q&e=>. The discussion thread for the SPIP was conducted here [lists.apache.org]<https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.apache.org_thread.html_2fe82b6b86daadb1d2edaef66a2d1c4dd2f45449656098ee38c50079-40-253Cdev.spark.apache.org-253E&d=DwMFJg&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=7WzLIMu3WvZwd6AMPatqn1KZW39eI6c_oflAHIy1NUc&m=UG2t14gfU8QHfoj4tUD__9bIVg1xxTM3R8GHmvMUXTU&s=kSJizQH7v4OHG6D7aVsLA-m0ApZxOa24CzHZv1EzLxg&e=>. Please vote on whether or not this proposal is agreeable to you. Thanks! -Matt Cheah -- Ryan Blue Software Engineer Netflix -- John -- -Dhruve Ashar
