Sounds fine, we probably needed SPARK-28775 anyway. I merged that and SPARK-28749. It looks like it's just the one you're talking about right now, SPARK-28699. The rest of the tests seemed to pass OK, release looks good, but bears more testing by everyone out there before a next RC.
On Tue, Aug 20, 2019 at 12:10 AM Wenchen Fan <cloud0...@gmail.com> wrote: > > Unfortunately, I need to -1. > > Recently we found that the repartition correctness bug can still be > reproduced. The root cause has been identified and there are 2 PRs to fix 2 > related issues: > https://github.com/apache/spark/pull/25491 > https://github.com/apache/spark/pull/25498 > > I think we should have this fix in 2.3 and 2.4. > > Thanks, > Wenchen > > On Tue, Aug 20, 2019 at 7:32 AM Dongjoon Hyun <dongjoon.h...@gmail.com> wrote: >> >> Thank you for testing, Sean and Herman. >> >> There are three reporting until now. >> >> 1. SPARK-28775 is for JDK 8u221+ testing at Apache Spark 3.0/2.4/2.3. >> 2. SPARK-28749 is for Scala 2.12 Python testing at Apache Spark 2.4 only. >> 3. SPARK-28699 is for disabling radix sort for ShuffleExchangeExec at Apache >> Spark 3.0/2.4/2.3. >> >> Both (1) and (2) are nice-to-have and test-only fixes. (3) could be a >> correctness issue, but it seems that there are some other approaches. >> I'm monitoring all reports. Let's see. For now, I'd like to continue 2.4.4 >> RC1 voting for more testing. >> >> Bests, >> Dongjoon. --------------------------------------------------------------------- To unsubscribe e-mail: dev-unsubscr...@spark.apache.org
